Ashby/Ludo-3D
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bot and player bug fixes.

Browse Source 
Fixes for selecting wrong player, switching player.
This commit is contained in:
Ashby Issac 2026-01-29 15:45:49 +05:30
parent d93ffe6fad
commit d247307e51
2 changed files with 54 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
Assets/Scripts/Gameplay/GameplayManager.cs
View File

@ -99,6 +99,7 @@ public class GameplayManager : MonoBehaviour, IBase, IBootLoader, IDataLoader
{ {
// TODO :: 2P, 3P, 4P // TODO :: 2P, 3P, 4P
allPlayerTypes = new List<PlayerType> { PlayerType.Player1, PlayerType.Player2, PlayerType.Player3, PlayerType.Player4 }; allPlayerTypes = new List<PlayerType> { PlayerType.Player1, PlayerType.Player2, PlayerType.Player3, PlayerType.Player4 };
// allPlayerTypes = new List<PlayerType> { PlayerType.Player1, PlayerType.Player3 };
playerBaseHandler.InitPlayerTypes(allPlayerTypes); playerBaseHandler.InitPlayerTypes(allPlayerTypes);
InitCurrentGamePlayerInfo(); InitCurrentGamePlayerInfo();
@ -258,7 +259,7 @@ public class GameplayManager : MonoBehaviour, IBase, IBootLoader, IDataLoader
// What happens when you get a 6 // What happens when you get a 6
private void SelectPawnFromBotBase() private void SelectPawnFromBotBase()
{ {
if (availPlayers.Count() < 1 && !CanRollDiceAgain || !botTypesInGame.Contains(currentPlayerTypeTurn)) return; // Have a better check here if (canSwitchPlayer || availPlayers.Count() < 1 && !CanRollDiceAgain || !botTypesInGame.Contains(currentPlayerTypeTurn)) return; // Have a better check here
Debug.Log($"CallTest: SelectPawnFromBotBase: {currentPlayerTypeTurn}"); Debug.Log($"CallTest: SelectPawnFromBotBase: {currentPlayerTypeTurn}");
var botPawnsDictForCurrentPlayer = botRuntimeMovementData[currentPlayerTypeTurn]; // set the data inside this dict var botPawnsDictForCurrentPlayer = botRuntimeMovementData[currentPlayerTypeTurn]; // set the data inside this dict
@ -303,7 +304,7 @@ public class GameplayManager : MonoBehaviour, IBase, IBootLoader, IDataLoader
} }
int lastIndex = tilesManager.GetGeneralTilesLength() - 1; int lastIndex = tilesManager.GetGeneralTilesLength() - 1;
int index = possibleLandingIndex > lastIndex ? (possibleLandingIndex - lastIndex) - 1 : possibleLandingIndex; int index = possibleLandingIndex > lastIndex ? possibleLandingIndex - lastIndex - 1 : possibleLandingIndex;
Tile possibleTileData = tilesManager.RetrieveTileBasedOnIndex(index); Tile possibleTileData = tilesManager.RetrieveTileBasedOnIndex(index);
Debug.Log($"AI playerPawn :: {playerPawn.name} :: state: {playerPawn.GetPlayerState()}, possibleLandingIndex: {possibleLandingIndex > playerGameDatasDict[currentPlayerTypeTurn].endIndex}"); Debug.Log($"AI playerPawn :: {playerPawn.name} :: state: {playerPawn.GetPlayerState()}, possibleLandingIndex: {possibleLandingIndex > playerGameDatasDict[currentPlayerTypeTurn].endIndex}");
@ -312,9 +313,16 @@ public class GameplayManager : MonoBehaviour, IBase, IBootLoader, IDataLoader
if (playerPawn.GetPlayerState() == PlayerState.InFinishingPath || possibleLandingIndex > playerGameDatasDict[currentPlayerTypeTurn].endIndex) if (playerPawn.GetPlayerState() == PlayerState.InFinishingPath || possibleLandingIndex > playerGameDatasDict[currentPlayerTypeTurn].endIndex)
{ {
botPawnsDictForCurrentPlayer[playerPawn.PlayerId] = BotMove.FinishingPathMove; if (playerPawn.CanSelectPlayer)
savedPlayerId = playerPawn.PlayerId; {
break; botPawnsDictForCurrentPlayer[playerPawn.PlayerId] = BotMove.FinishingPathMove;
savedPlayerId = playerPawn.PlayerId;
break;
}
else
{
botPawnsDictForCurrentPlayer[playerPawn.PlayerId] = BotMove.NoMoves;
}
} }
else if (possibleTileData.IsSafeZone || playerPawn.GetPlayerState() == PlayerState.InHome) else if (possibleTileData.IsSafeZone || playerPawn.GetPlayerState() == PlayerState.InHome)
{ {
@ -326,13 +334,16 @@ public class GameplayManager : MonoBehaviour, IBase, IBootLoader, IDataLoader
} }
else else
{ {
Debug.Log($"AI playerPawn :: {playerPawn.name} :: normalMove"); Debug.Log($"AI playerPawn :: {playerPawn.name} :: {playerPawn.PlayerId} :: normalMove");
botPawnsDictForCurrentPlayer[playerPawn.PlayerId] = BotMove.NormalMove; botPawnsDictForCurrentPlayer[playerPawn.PlayerId] = BotMove.NormalMove;
} }
} }
List<int> playerIds = new List<int>(); List<int> playerIds = new List<int>();
if (savedPlayerId != -1 && playerGameDatasDict[currentPlayerTypeTurn].playerPawnsDict[savedPlayerId].CanSelectPlayerFromHome)
if (savedPlayerId != -1)
Debug.Log($"SavedPlayerId: {savedPlayerId}, CanSelectPlayer: {playerGameDatasDict[currentPlayerTypeTurn].playerPawnsDict[savedPlayerId].CanSelectPlayer}");
if (savedPlayerId != -1 && playerGameDatasDict[currentPlayerTypeTurn].playerPawnsDict[savedPlayerId].CanSelectPlayer)
{ {
pawn = playerGameDatasDict[currentPlayerTypeTurn].playerPawnsDict[savedPlayerId]; // chances are when one of the character reaches towards the finishing point pawn = playerGameDatasDict[currentPlayerTypeTurn].playerPawnsDict[savedPlayerId]; // chances are when one of the character reaches towards the finishing point
} }
@ -412,13 +423,25 @@ public class GameplayManager : MonoBehaviour, IBase, IBootLoader, IDataLoader
canSwitchPlayer = false; canSwitchPlayer = false;
// provide option to select a pawn from the list // provide option to select a pawn from the list
// also play a simple animation before selecting // also play a simple animation before selecting
EnablePlayerSelectionStates(true);
CanRollDiceAgain = true; CanRollDiceAgain = true;
pointerMeshRend.material = selectMat;
foreach (var playerPawn in playerGameDatasDict[currentPlayerTypeTurn].playerPawnsDict)
if (playerPawn.Value.GetPlayerState() == PlayerState.InFinishingPath)
playerPawn.Value.SetPlayerSelectionState(false);
Debug.Log($"### AreAllPawnsInFinishingPath");
if (AreAllPawnsInFinishingPath()) if (AreAllPawnsInFinishingPath())
{
CanRollDice = true; CanRollDice = true;
pointerMeshRend.material = selectMat; return;
}
Debug.Log($"### EnablePlayerSelectionStates");
EnablePlayerSelectionStates(true);
// pointerMeshRend.materials[0] = selectMat; // pointerMeshRend.materials[0] = selectMat;
} }
else // if there are any other pawns that are in safe or moving state else // if there are any other pawns that are in safe or moving state
@ -426,31 +449,37 @@ public class GameplayManager : MonoBehaviour, IBase, IBootLoader, IDataLoader
// for player's logic // for player's logic
InitActivePlayers(); InitActivePlayers();
Debug.Log($"availPlayers: {playerGameDatasDict[currentPlayerTypeTurn].playerPawnsDict.Values.Select(pawn => pawn).Where(pawn => pawn.GetPlayerState() == PlayerState.InHome).ToList().Count}");
int customAvailPlayers = availPlayers.Count(); int customAvailPlayers = availPlayers.Count();
Debug.Log($"before CustomAvailablePlayers: {customAvailPlayers}"); Debug.Log($"before CustomAvailablePlayers: {customAvailPlayers}");
List<int> indexesToRemove = new List<int>();
foreach (PlayerPawn playerPawn in availPlayers) for (int i = 0; i < availPlayers.Count; i++)
{ {
Debug.Log($"## playerPawn.GetPlayerState(): {playerPawn.GetPlayerState()}"); Debug.Log($"## playerPawn.GetPlayerState(): {availPlayers[i].GetPlayerState()}");
if (playerPawn.GetPlayerState() == PlayerState.InFinishingPath) if (availPlayers[i].GetPlayerState() == PlayerState.HasFinished || availPlayers[i].GetPlayerState() == PlayerState.InHome) continue;
if (availPlayers[i].GetPlayerState() == PlayerState.InFinishingPath)
{ {
Debug.Log($"diceRolledValue: {diceRolledValue}, FinishingDataLen: {tilesManager.GetFinishingTileDataLength(currentPlayerTypeTurn)}, playerPawn.CurrentTileIndex: {playerPawn.CurrentTileIndex}"); Debug.Log($"diceRolledValue: {diceRolledValue}, FinishingDataLen: {tilesManager.GetFinishingTileDataLength(currentPlayerTypeTurn)}, playerPawn.CurrentTileIndex: {availPlayers[i].CurrentTileIndex}");
if (diceRolledValue <= tilesManager.GetFinishingTileDataLength(currentPlayerTypeTurn) - (playerPawn.CurrentTileIndex + 1)) if (diceRolledValue <= tilesManager.GetFinishingTileDataLength(currentPlayerTypeTurn) - (availPlayers[i].CurrentTileIndex + 1))
{ {
playerPawn.SetPlayerSelectionState(true); availPlayers[i].SetPlayerSelectionState(true);
} }
else else
{ {
indexesToRemove.Add(i);
availPlayers[i].SetPlayerSelectionState(false);
customAvailPlayers--; customAvailPlayers--;
} }
continue; continue;
} }
playerPawn.SetPlayerSelectionState(true); availPlayers[i].SetPlayerSelectionState(true);
} }
foreach (int i in indexesToRemove) availPlayers.RemoveAt(i);
// if (availPlayers.Count() < 1) // if (availPlayers.Count() < 1)
Debug.Log($"CustomAvailablePlayers: {customAvailPlayers}"); Debug.Log($"CustomAvailablePlayers: {customAvailPlayers}");
canSwitchPlayer = customAvailPlayers < 1; canSwitchPlayer = customAvailPlayers < 1;
@ -473,7 +502,9 @@ public class GameplayManager : MonoBehaviour, IBase, IBootLoader, IDataLoader
bool areAllPawnsInFinishingPath = false; bool areAllPawnsInFinishingPath = false;
foreach (var pawn in playerGameDatasDict[currentPlayerTypeTurn].playerPawnsDict) foreach (var pawn in playerGameDatasDict[currentPlayerTypeTurn].playerPawnsDict)
{ {
if (pawn.Value.GetPlayerState() == PlayerState.InFinishingPath && pawn.Value.GetPlayerState() != PlayerState.HasFinished) if (pawn.Value.GetPlayerState() == PlayerState.HasFinished) continue;
if (pawn.Value.GetPlayerState() == PlayerState.InFinishingPath)
{ {
areAllPawnsInFinishingPath = true; areAllPawnsInFinishingPath = true;
continue; continue;

9
Assets/Scripts/Gameplay/Player/PlayerPawn.cs
View File

@ -21,10 +21,11 @@ public class PlayerPawn : MonoBehaviour
{ {
[SerializeField] private PlayerState playerState; [SerializeField] private PlayerState playerState;
public bool CanSelectPlayerFromHome public bool CanSelectPlayer
{ {
get; private set; get; private set;
} }
private GameplayManager gameplayManager; private GameplayManager gameplayManager;
public int CurrentTileIndex public int CurrentTileIndex
@ -59,8 +60,8 @@ public class PlayerPawn : MonoBehaviour
public void SetPlayerSelectionState(bool state) public void SetPlayerSelectionState(bool state)
{ {
CanSelectPlayerFromHome = state; CanSelectPlayer = state;
if (CanSelectPlayerFromHome) if (CanSelectPlayer)
{ {
// TODO :: Play animation for selecting any of the players // TODO :: Play animation for selecting any of the players
} }
@ -96,7 +97,7 @@ public class PlayerPawn : MonoBehaviour
private void OnMouseDown() private void OnMouseDown()
{ {
if (IsBotPlayer || !CanSelectPlayerFromHome) return; if (IsBotPlayer || !CanSelectPlayer) return;
SetGameplayManager(); SetGameplayManager();
gameplayManager.OnPawnSelected(this); gameplayManager.OnPawnSelected(this);